chore: bump black and mypy to most recent with py 3.8 support#71
chore: bump black and mypy to most recent with py 3.8 support#71
Conversation
Removed line
parser.add_argument_group(grammars)
which a) was never meant to be allowed,
and b) isn't required anyway, it doesn't actually do anything.
See the deprecation note in
https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group
|
@cclauss Turned out bumping mypy was not so hard, and black trivial up to 24.8. |
| "black==24.8.0", | ||
| "isort", | ||
| "mypy==0.991", | ||
| "mypy==1.13.0", |
There was a problem hiding this comment.
Are these tools run OUTSIDE of pre-commit?
There was a problem hiding this comment.
Sometimes, yes, though not automatically. I certainly prefer to have them installed in my venv and ready to call from the bash prompt. In all my projects, pip install -e .[dev] will give me black, isort, mypy, usually flake8 too, with whatever configuration is needed to "just work".
|
These can be installed with
|
Oh, oops, indeed, it is totally redundant! |
3 participants
Removed line
parser.add_argument_group(grammars)
which a) was never meant to be allowed,
and b) isn't required anyway, it doesn't actually do anything.
See the deprecation note in
https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument_group
PR Goal?
just keeping the repo tidy, in the same spirit as #68 and #70
Feedback sought?
rubber stamping
Priority?
low
Tests added?
n/a
How to test?
Run
pre-commit run --all-filesand see no warnings anymoreRun
soundswallower -h,soundswallower -a foo -t barand see that the mutually exclusive group still works.Confidence?
high
Version change?
no